Extend locateNodes with a locator to get navigable's container element #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/container-locator
branch
3 times, most recently
from
b6e0478 to
0a2b364
Compare
OrKoN
added
needs-discussion
whimboo
reviewed
Nov 11, 2024
OrKoN
force-pushed
the
orkon/container-locator
branch
2 times, most recently
from
0748244 to
628c9e0
Compare
OrKoN
changed the title
jgraham
requested changes
Nov 29, 2024
OrKoN
force-pushed
the
orkon/container-locator
branch
from
628c9e0 to
234a6ad
Compare
sadym-chromium
approved these changes
Dec 17, 2024
OrKoN
force-pushed
the
orkon/container-locator
branch
from
bda9ebe to
0729b55
Compare
whimboo
reviewed
Dec 19, 2024
| @@ -2984,6 +2985,13 @@ browsingContext.CssLocator = { | |||
| value: text | |||
| } | |||
|
|
|||
| browsingContext.ContextLocator = { | |||
There was a problem hiding this comment.
I still find it puzzling when naming it ContextLocator but then returning a Node which is the container element of a context. Why was it changed from ContainerLocator?
There was a problem hiding this comment.
Changed on request by @jgraham because the locator name reflects the criteria for search and not the return value. I.e., browsingContext.ContextLocator locates by a context selector, browsingContext.CssLocator locates by a CSS selector.
There was a problem hiding this comment.
I’m still not entirely sold on this API, but if @jgraham is okay with it, we can move forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new locator called
context: when called for a parent navigable, given a child navigable as a locator, it locates the container element for the child navigable that is located within the parent navigable. While providing the parent navigable is redundant and it can be computed based on the child navigable, the interface matches existing locators which all select a node within the parent navigable that matches the locator criteria. In this case, the criterion is the child navigable identifier.Providing start nodes to this locator would currently trigger an invalid argument error but eventually it could be supported if there is a use case.
Closes #794
Preview | Diff