Correct tests by sections #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
reviewed
Oct 29, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
aljones15
force-pushed
the
correct-tests-by-sections
branch
from
419eea8 to
1a7e6d4
Compare
BigBlueHat
reviewed
Oct 30, 2024
| @@ -24,7 +25,7 @@ const {match} = endpoints.filterByTag({ | |||
| }); | |||
| const should = chai.should(); | |||
|
|
|||
| describe('Algorithms - Transformation (eddsa-jcs-2022)', function() { | |||
| describe('eddsa-jcs-2022 - Algorithms - Transformation', function() { | |||
There was a problem hiding this comment.
Good move. I like the cryptosuite name first. Thanks!
There was a problem hiding this comment.
it matches the original better, perhaps we should make a style guide and ensure cryptosuite is first? Data Integrity still lists itself first. Also, the sections are nice, but are not necessarily sorted alphabetically in the report which is a little annoying.
PatStLouis
approved these changes
Oct 30, 2024
TallTed
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features: