fix context and missing vcHolder implementations #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PatStLouis <[email protected]>
BigBlueHat
approved these changes
Dec 10, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
@TallTed Thank you for the edits/suggestion, I've committed them. Please approve the corrections so we can merge this PR. |
dlongley
reviewed
Dec 13, 2024
dlongley
reviewed
Dec 13, 2024
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
|
@TallTed since @dlongley pointed out the the word "Derive" was referring to the "Derive endpoint", the past tense doesn't apply since this is now a noun designating a thing. I've had to revert the suggestions. Could you approve this please? |
dlongley
approved these changes
Dec 13, 2024
TallTed
reviewed
Dec 17, 2024
TallTed
reviewed
Dec 17, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
msporny
approved these changes
Dec 17, 2024
TallTed
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.