Skip to content

Commit

Permalink
Add note about section 11.1 covered by 4.6.
Browse files Browse the repository at this point in the history
Multiple language usage is optional, so these MAY be expanded later if/as
needed.
  • Loading branch information
BigBlueHat committed Aug 15, 2024
1 parent 838a7ee commit a9f2160
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
7 changes: 7 additions & 0 deletions tests/4-6-names-and-descriptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ const {match} = filterByTag({tags: [tag]});
// appear anywhere. However, we have tests for them (on `issuer` so far), so
// keeping them in play seems prudent/useful. They can be expanded later also
// to cover `name` and/or `description` anywhere they appear.

// Also, the normative section...
// 11.1 Language and Base Direction https://w3c.github.io/vc-data-model/#language-and-base-direction
// ...is partially covered by these tests. A more complete approach would test
// any occurance of a "Value Object" (detecting `@value` throughout the tree)
// and test for conformat member properties (`@language` and `@direction`) and
// fail on the existence of any other properties.
describe('Names and Descriptions', function() {
setupMatrix.call(this, match);
for(const [name, implementation] of match) {
Expand Down
3 changes: 0 additions & 3 deletions tests/50-advanced-concepts.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,3 @@ describe('Advanced Concepts', function() {

// 7.2 Problem Details https://w3c.github.io/vc-data-model/#problem-details
// TODO: optionaly response format; but we could write tests for it

// 11.1 Language and Base Direction https://w3c.github.io/vc-data-model/#language-and-base-direction
// TODO: possibly already covered by Name and Description tests

0 comments on commit a9f2160

Please sign in to comment.