Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests to support StatusList2021 type #13

Merged
merged 39 commits into from
Jul 11, 2022
Merged

Refactor tests to support StatusList2021 type #13

merged 39 commits into from
Jul 11, 2022

Conversation

JSAssassin
Copy link
Contributor

@JSAssassin JSAssassin commented May 12, 2022 •
edited
Loading

This is waiting on the release of the new issuer and verifier on QA, and update of DB issuer and verifier instances on vc-api-test-suite-implementations lib. QA has been updated

All 14 tests should pass.

@JSAssassin JSAssassin changed the base branch from main to use-implemented May 12, 2022 18:27
Base automatically changed from use-implemented to main May 13, 2022 20:24
@JSAssassin JSAssassin mentioned this pull request May 19, 2022
Merged
@JSAssassin JSAssassin force-pushed the test-localhost branch 2 times, most recently from 0bdf50e to 79bf308 Compare May 25, 2022 14:30
@JSAssassin JSAssassin marked this pull request as ready for review June 16, 2022 16:31
@JSAssassin JSAssassin mentioned this pull request Jun 16, 2022
Closed
@JSAssassin JSAssassin mentioned this pull request Jun 29, 2022
Merged
JSAssassin added 19 commits July 5, 2022 10:38
@JSAssassin
Refactor tests for issue and add helper function to assert SlCredential.
1a637ce
@JSAssassin
Move code to create validVc into a helper function.
07e8907
@JSAssassin
Update vc-generator and move documentLoader.js.
b0851f5
@JSAssassin
Move contexts.js to tests.
65f4ed7
@JSAssassin
Update README.md.
d6f2a0e
@JSAssassin
Add a getSlc helper function.
5af4d19
@JSAssassin
Add createRequestBody helper function.
7b3809e
@JSAssassin
Move assertion for credentialSubject.
4831532
@JSAssassin
Fix typo.
7c590cb
@JSAssassin
Refactor _validVc().
ee1826e
@JSAssassin
Move assertions for verification into separate helper functions.
1bfdade
@JSAssassin
Remove unused dependencies.
d10ac89
@JSAssassin
Update to use vc-api-test-suite-implementations#update-db-zcaps.
02b746d
@JSAssassin
Add assertion for credentialStatus.statusPurpose.
89063b3
@JSAssassin
Add issuer tests for credential with suspension type statusPurpose.
01ab891
@JSAssassin
Refactor createValidVc().
f7d0cc2
@JSAssassin
Update vc-generator.
1c27f49
@JSAssassin
Pass issuer instead of issuer id.
e0efe48
@JSAssassin
Remove .only.
41be419
@JSAssassin JSAssassin requested a review from aljones15 July 8, 2022 21:19
aljones15
aljones15 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this as it gets some really needed tests into the report. Good work here and wow really impressed with this! Feel free to address comments at a later time.

@JSAssassin JSAssassin mentioned this pull request Jul 11, 2022
Open
@JSAssassin JSAssassin merged commit 0804dbf into main Jul 11, 2022
@JSAssassin JSAssassin deleted the test-localhost branch July 11, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljones15 aljones15 aljones15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSAssassin @aljones15