Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-Triples base direction tests. #117

Merged
merged 9 commits into from
Nov 2, 2023
Merged

N-Triples base direction tests. #117

merged 9 commits into from
Nov 2, 2023

Conversation

gkellogg
Copy link
Member

Positive and Negative tests for the use of base direction in N-Triples.

@gkellogg gkellogg requested a review from rubensworks October 24, 2023 18:37
@@ -0,0 +1 @@
<http://example/a> <http://example/b> "Hello"@en--ltr .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: there are two spaces between <http://example/a> and <http://example/b>.
Not wrong, but a single space might be a bit nicer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I'm not able to test it on my end though. I have to do some implementation work first.

@gkellogg gkellogg merged commit a238425 into main Nov 2, 2023
@gkellogg gkellogg deleted the base-direction branch November 2, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants