Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinterpret assumed test base #116

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Reinterpret assumed test base #116

merged 2 commits into from
Oct 17, 2023

Conversation

gkellogg
Copy link
Member

cc/ @jeswr

@gkellogg
Changes the definition of assumedTestBase and revises the trig/turtle…
af8e290 
…-subm-01 test results to be compatible with running without assumedTestBase.

Fixes #113
@gkellogg
Adds assumedTestBase to RDF/XML tests.
9ee37c4
@gkellogg gkellogg requested a review from afs October 16, 2023 18:51
afs
afs approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@afs afs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked: Jena reports OK (1007 tests) for rdf11.

@gkellogg gkellogg merged commit a0b910e into main Oct 17, 2023
2 checks passed
@gkellogg gkellogg deleted the reinterpret-assumedTestBase branch October 17, 2023 15:58
@jeswr
Copy link
Member

jeswr commented Oct 17, 2023

@gkellogg Since the assumed base is https could we also update mf:action and the mf:result in the manifests to use https rather than http?

@jeswr jeswr mentioned this pull request Oct 17, 2023
Closed
@afs
Copy link
Contributor

afs commented Oct 17, 2023

You mean change the vocabulary?

All the uses are with relative URIs.

@jeswr
Copy link
Member

jeswr commented Oct 18, 2023

Ah, ignore me - I was viewing things using the RDF Browser which resolves relative URIs before displaying the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpt Tpt Tpt approved these changes

@afs afs afs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move of RDF tests breaks existing test runners
4 participants
@gkellogg @jeswr @afs @Tpt