Rename resolveStream to resolveRepresentation #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
approved these changes
Oct 3, 2020
brentzundel
approved these changes
Oct 7, 2020
msporny
approved these changes
Oct 8, 2020
|
Editorial, multiple positive reviews, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent conversations it was proposed that the
resolveStreamfunction should be renamed to resolveRepresentation, since the main difference is thatresolvereturns the DID document's abstract data model, whereasresolveRepresentationreturns the DID document in one of the conformant representations.I think this change will have a positive effect on the current discussion around the abstract data model and representations.
E.g. see:
Preview | Diff