Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial: refactor aria.js #2408

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

editorial: refactor aria.js #2408

wants to merge 2 commits into from

Conversation

pkra
Copy link
Member

@pkra pkra commented Jan 3, 2025 •
edited
Loading

Part of #2230

Partially moved from w3c/aria-common#106 at caf8e9e

From the original PR:

Much work to be done.

  • add a very simple test
    • test.sh runs respec on ARIA before/after applying aria.js changes and diffs the two results
  • rough goals
    • clarify (e.g., switch to const/let, replace reused variable names with unique ones)
    • simplify (e.g., loops over querySelectorAll, use sets instead of filtering)
    • revise HTML string creation
    • extract loops
  • steps
    • pdef, sdef loop
    • generating HTML for indices of (global) states&properties as well as role=roletype
    • rdef loop
    • roleInfo loop
    • propList loop
    • generate HTML for role-related indices, sub-Roles
    • clean-up
  • continuation
    • rewrite subRoles code
  • TODO
  • Future
    • turn everything into ESM? [to modularize code]
    • review other JS files (to prepare their refactorings)

pkra added 2 commits January 3, 2025 17:07
@pkra
editorial: refactor aria.js
3a8ec40 
Copies the proposed refactor from
w3c/aria-common#106
at caf8e9e
The PR has many separate commits for easier review.
@pkra
editorial: add simple test script for aria.js
0ead460 
Copies from
w3c/aria-common#106
at caf8e9e
The PR has many separate commits for easier review.
@pkra pkra requested a review from spectranaut January 3, 2025 16:12
@netlify Netlify
Copy link

netlify bot commented Jan 3, 2025 •
edited
Loading

✅ Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 0ead460
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67780c6cbc5f9e0008712e2e
😎 Deploy Preview https://deploy-preview-2408--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pkra pkra added Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo labels Jan 3, 2025
@pkra pkra added this to the 2025 milestone Jan 3, 2025
@pkra pkra mentioned this pull request Jan 3, 2025
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spectranaut spectranaut Awaiting requested review from spectranaut

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
2025
Development

Successfully merging this pull request may close these issues.
1 participant
@pkra