Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue #88 - Distorted images on stores #90

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

vsseixaso
Copy link
Contributor

@vsseixaso vsseixaso commented Jul 18, 2024

What problem is this solving?

This PR aims to fix the Issue #88. An issue generated in release v0.22.0, which allowed setting the image height of an image-list via Admin Site Editor, but set maxHeight as default for the image's height prop. This distorted the image in accounts that had a value set for maxHeight.

With this PR, the image height will no longer receive maxHeight as the default value, requiring the user to set a value for the prop via Admin Site Editor.

How to test it?

Access the Site Editor and follow this sequence of blocks:

HEADER > Header-Desktop > Slider Layout then click on Image List.

Then, access any image and set a value in the Height field, example: 300px.
Save and apply, now you can see the height of the image is different, but defined by your change, and not by default.

Screenshots or example usage:

Before

image

After

image

Describe alternatives you've considered, if any.

Follow up: Add an option to set height for all images in the image-list, for now it's necessary set one by one.

How does this PR make you feel? 🔗

@vsseixaso vsseixaso requested a review from a team as a code owner July 18, 2024 14:29
@vsseixaso vsseixaso requested review from gvc, emersonlaurentino and eduardoformiga and removed request for a team July 18, 2024 14:29
Copy link

vtex-io-ci-cd bot commented Jul 18, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 18, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

Fails
🚫

We follow keepachangelog standards.

Please, add a section to your changelog entry. Example:

 ## [Unreleased]

+ ### Fixed
 - Issue with image sizing in the SKU Selector.

You can use one of the following sections:

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

Generated by 🚫 dangerJS against 56053b7

@vsseixaso vsseixaso added the bug Something isn't working label Jul 19, 2024
@vsseixaso vsseixaso changed the title Draft: Fix: Distorted images on stores Fix: Issue #88 - Distorted images on stores Jul 19, 2024
Copy link

@vmourac-vtex vmourac-vtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@vsseixaso vsseixaso merged commit c5df56d into master Aug 7, 2024
5 of 6 checks passed
@vsseixaso vsseixaso deleted the fix/image-list-height branch August 7, 2024 17:50
Copy link

vtex-io-ci-cd bot commented Aug 7, 2024

Your PR has been merged! App is being published. 🚀
Version 0.22.0 → 0.22.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

vsseixaso added a commit that referenced this pull request Sep 4, 2024
vsseixaso added a commit that referenced this pull request Sep 4, 2024
#### What problem is this solving?

Remove the broken code from v0.22.0 and v0.22.1.

#### How to test it?

The fix was linked in
`carrefourar`([workspace](https://vsseixaso--carrefourar.myvtex.com/))

#### Screenshots or example usage:

![Screenshot 2024-09-04 at 11 50
04 AM](https://github.com/user-attachments/assets/34e63681-5659-4913-b540-724709ea91be)

#### Related to / Depends on

PR to [v0.22.0](#87) and
[v0.22.1](#90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants