-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Issue #88 - Distorted images on stores #90
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
#### What problem is this solving? Remove the broken code from v0.22.0 and v0.22.1. #### How to test it? The fix was linked in `carrefourar`([workspace](https://vsseixaso--carrefourar.myvtex.com/)) #### Screenshots or example usage: ![Screenshot 2024-09-04 at 11 50 04 AM](https://github.com/user-attachments/assets/34e63681-5659-4913-b540-724709ea91be) #### Related to / Depends on PR to [v0.22.0](#87) and [v0.22.1](#90)
What problem is this solving?
This PR aims to fix the Issue #88. An issue generated in release v0.22.0, which allowed setting the image height of an
image-list
via Admin Site Editor, but setmaxHeight
as default for the image'sheight
prop. This distorted the image in accounts that had a value set for maxHeight.With this PR, the image height will no longer receive maxHeight as the default value, requiring the user to set a value for the prop via Admin Site Editor.
How to test it?
Access the Site Editor and follow this sequence of blocks:
HEADER > Header-Desktop > Slider Layout then click on Image List.
Then, access any image and set a value in the
Height
field, example:300px
.Save and apply, now you can see the height of the image is different, but defined by your change, and not by default.
Screenshots or example usage:
Before
After
Describe alternatives you've considered, if any.
Follow up: Add an option to set height for all images in the image-list, for now it's necessary set one by one.
How does this PR make you feel? 🔗