Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical Scaling #483

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Vertical Scaling #483

merged 3 commits into from
Jan 29, 2025

Conversation

salesfelipe
Copy link
Contributor

@salesfelipe salesfelipe commented Jan 27, 2025 •
edited
Loading

What problem is this solving?

  • Change the scaling strategy to improve the usage of Resources.

How should this be manually tested?

Workspace

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Linked this PR to a Clubhouse story (if applicable).
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@salesfelipe salesfelipe added the enhancement New feature or request label Jan 27, 2025
@salesfelipe salesfelipe self-assigned this Jan 27, 2025
@salesfelipe salesfelipe requested a review from a team as a code owner January 27, 2025 14:32
@vtex-io-ci-cd VTEX IO CI/CD
Copy link

vtex-io-ci-cd bot commented Jan 27, 2025 •
edited by salesfelipe
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 27, 2025 •
edited by salesfelipe
Loading

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

salesfelipe
salesfelipe commented Jan 27, 2025
View reviewed changes
node/index.ts
@@ -27,6 +26,7 @@ metrics.trackCache('segment', segmentCache)
metrics.trackCache('search', searchCache)
metrics.trackCache('messages', messagesCache)
metrics.trackCache('vbase', vbaseCache)
metrics.trackCache('apps', appsCache)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing

@salesfelipe salesfelipe merged commit 686ff09 into v1.x Jan 29, 2025
7 of 11 checks passed
@salesfelipe salesfelipe deleted the chore/changeScaling branch January 29, 2025 14:56
@vtex-io-ci-cd VTEX IO CI/CD
Copy link

vtex-io-ci-cd bot commented Jan 29, 2025

Your PR has been merged! App is being published. 🚀
Version 1.73.0 → 1.74.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luarakerlen luarakerlen luarakerlen approved these changes

Assignees

@salesfelipe salesfelipe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salesfelipe @luarakerlen