Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project to use Poetry and add PR Gate #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vs4vijay
Copy link
Owner

@vs4vijay vs4vijay commented Jun 28, 2024

This pull request introduces several significant changes to the ScanMaster project, focusing on dependency management, continuous integration, and code organization.

  • Dependency Management: Migrates the project from using pip and a requirements.txt file for managing dependencies to using Poetry. This is achieved by deleting the requirements.txt and setup.sh files and adding a pyproject.toml file to define project dependencies and configurations. The README.md file is updated to reflect these changes, instructing users to use Poetry for installation.
  • Continuous Integration: Establishes a PR Gate using GitHub Actions. A new workflow file .github/workflows/pr_gate.yml is added, defining steps for linting and testing the codebase on pull requests.
  • Code Organization: Refactors the scanner implementations to improve code reuse and maintenance. Changes in scanners/__init__.py and modifications to scanners/openvas_scanner.py are part of this effort, aiming to centralize and streamline the way scanner modules are imported and utilized within the project.

For more details, open the Copilot Workspace session.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant