-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor styling #1268
Refactor styling #1268
Conversation
fd5d67c
to
711a6ed
Compare
8c9fbec
to
612b9d2
Compare
e7991ed
to
7c46d98
Compare
7c46d98
to
fef7aa7
Compare
c19f3c2
to
c00aa87
Compare
The reveal template visual changes are legit, we were not respecting the font sizes specified by nbconvert: https://github.com/jupyter/nbconvert/blob/main/share/templates/reveal/index.html.j2#L80 we now do Please update galata references |
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2023-03-16 10:30:38.340276051 +0000
+++ /dev/fd/62 2023-03-16 10:30:38.340276051 +0000
@@ -4,49 +4,49 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® E5-2673 v4",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
"l1d": 65536,
"l1i": 65536,
"l2": 524288,
- "l3": 52428800
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "79",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.3,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "1",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
},
"mem": {
- "total": 7281278976
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
"build": "",
- "codename": "Jammy Jellyfish",
+ "codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.15.0-1034-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
- "release": "22.04.2 LTS",
- "serial": "2eb8d65c617f413abe6f4d67d8f306ea",
+ "release": "20.04.3 LTS",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
Thanks @martinRenou |
References
Make a separate style bundle to inject in the page.
If we were to use the style bundle produced by the Voila app we would pull the entire JupyterLab application CSS, breaking custom templates like classic/vuetify/reveal.
This will make #1249 easier by providing a way to inject the CSS needed for JupyterLab mime renderers without breaking template's CSS.