Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor styling #1268

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Nov 30, 2022

References

Make a separate style bundle to inject in the page.

If we were to use the style bundle produced by the Voila app we would pull the entire JupyterLab application CSS, breaking custom templates like classic/vuetify/reveal.

This will make #1249 easier by providing a way to inject the CSS needed for JupyterLab mime renderers without breaking template's CSS.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/refactor_styling

@martinRenou martinRenou force-pushed the refactor_styling branch 2 times, most recently from fd5d67c to 711a6ed Compare November 30, 2022 09:50
@martinRenou martinRenou marked this pull request as ready for review November 30, 2022 09:55
@martinRenou martinRenou marked this pull request as draft November 30, 2022 10:21
@martinRenou martinRenou added this to the 0.5.0 milestone Jan 30, 2023
@martinRenou martinRenou force-pushed the refactor_styling branch 2 times, most recently from e7991ed to 7c46d98 Compare March 14, 2023 16:31
@martinRenou
Copy link
Member Author

The reveal template visual changes are legit, we were not respecting the font sizes specified by nbconvert: https://github.com/jupyter/nbconvert/blob/main/share/templates/reveal/index.html.j2#L80 we now do

Please update galata references

@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 145 <- [165 - 202 - 276] -> 476 79 <- [84 - 94 - 110] -> 146 76 <- [82 - 90 - 109] -> 151 75 <- [77 - 86 - 101] -> 127 2973 <- [3126 - 3240 - 3455] -> 5112 3057 <- [3102 - 3159 - 3256] -> 3495 3315 <- [3340 - 3373 - 3435] -> 3702 3424 <- [3442 - 3524 - 3623] -> 3650 2608 <- [2660 - 2683 - 2797] -> 3182 4757 <- [4882 - 5164 - 5591] -> 7075 5424 <- [5438 - 5454 - 5485] -> 5800 2311 <- [2318 - 2375 - 2431] -> 2807 3873 <- [3934 - 4040 - 4288] -> 4936
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2023-03-16 10:30:38.340276051 +0000
+++ /dev/fd/62	2023-03-16 10:30:38.340276051 +0000
@@ -4,49 +4,49 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
         "l2": 524288,
-        "l3": 52428800
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281278976
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
       "build": "",
-      "codename": "Jammy Jellyfish",
+      "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1034-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "22.04.2 LTS",
-      "serial": "2eb8d65c617f413abe6f4d67d8f306ea",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@martinRenou martinRenou marked this pull request as ready for review March 16, 2023 10:32
@martinRenou martinRenou requested review from jtpio and trungleduc March 16, 2023 10:32
@trungleduc
Copy link
Member

Thanks @martinRenou

@martinRenou martinRenou merged commit c60b6c0 into voila-dashboards:main Mar 16, 2023
@martinRenou martinRenou deleted the refactor_styling branch March 16, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants