Fix parsing ascii file with empty string #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ruff CI job is failing but the issue seems unrelated to this PR. |
|
I pushed a fix to the ruff issue 2de8e9c. This issue seemed dependent on the ruff version (worked locally with ruff 0.4.7 but failed with 0.5.7 as in CI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the proposed changes
The PR will fix a bug in parsing ASCII files with empty strings and add a test parsing a file generated with
Rscript -e "saveRDS('', file='empty.rds', ascii=TRUE, compress=FALSE)".Additional information
XDR files do not have this issue and a test case for them exists already.
Checklist before requesting a review