-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster xdr reader #32
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #32 +/- ##
===========================================
- Coverage 92.02% 91.98% -0.05%
===========================================
Files 6 7 +1
Lines 1104 1086 -18
===========================================
- Hits 1016 999 -17
+ Misses 88 87 -1 ☔ View full report in Codecov by Sentry. |
Here is approximate timing data for reference:
This data was created with the following (in bash):
|
Change copyright notice to make it clear that the copyright is shared between contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in accepting this. I was on vacation and had a "forced" digital detox. Approving and merging now.
No problem, thank you for merging! I hope you had a relaxing vacation! I'll open a PR for ASCII reader next. |
Just to let you know: I added your example (but limited to 5 iterations) as an asv benchmark to the package, to check for future performance regressions. I also added a new |
This PR adds faster reader for files in xdr format. Full arrays are read directly with numpy instead of reading element by element. As a positive side effect, deprecated xdrlib isn't needed anymore.
Related to #31. I have cherry-picked and rebased commits related to xdr reader improvements to this PR. There are also some structural changes that are open for discussion, for example, xdr reader is moved to
rdata/io/xdr.py
to simplify separation between different readers like (upcoming)rdata/io/ascii.py
. @vnmabus Could you review?