Fix issues of SimpleTest #2554
Merged
Fix issues of SimpleTest #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @harsht1737 , thanks for those fixes! Does it now work as described in the readme? CC: @arc-vmware |
|
Hi @teoparvanov, these are few of the fixes and some more of them are being analysed/fixed. Will drop a note to you when simpletest works as described in readme file. |
…oncord-bft into simpletest_fixes_harsht
arc-vmware
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: viewChangeCallback should be passed as an empty function wrapper rather than than nullptr as this function is called as no-op later in the code
Issue 2: aggregator has to be set for ReplicaBase at the time of Replica creation in SimpleTest Replica creation code