This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
added external GCP DB support for CredHub #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
Hi @kcboyle @jtarchie @nbconklin, is it any luck to merge PR this year? Or maybe it requires some improvements? Thanks, Konstantin. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds proper CredHub configuration for external DB on GCP
Without it deploy-ert job failed and you should manually configure PAS tile configuration.
It also adds logic to configure jobs according to version, some jobs exist in 2.1 and 2.2, but not in 2.3 and 2.4.
Expected result after the change:
pcf-pipelines on GCP completes without failure
Current result before the change:
deploy-ert job on GCP fails
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests