This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
Download stemcell from bosh.io task fixes #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike pivnet, the API_TOKEN isn't needed for acessing the publicly available bosh.io site.
Although unlikely outside testing, the copy command can fail if the pivnet-stemcells directory is empty. It's also generally a good idea to double quote the strings and keep the original file attributes.
The bosh_io_stemcells array only contains non-Ubuntu stemcells (i.e. CentOS), so the error message should reflect that.
- Use wget instead of curl so 404 or other errors fail the task instead of creating a 0 byte stemcell file. - Use native bash regex functionality to get the version and stemcell type from the raw stemcell file name.
|
@sneal Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
@sneal Thank you for signing the Contributor License Agreement! |
|
Did you ever evaluate that these changes work @sneal? It is a long process to validate ourselves, so it would be nice if someone has done a proper run through, first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still need to validate this is working end to end in a pipeline. I fixed some missing error checks, messages, etc.