Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for callable defaultValue in BooleanBone #1274

Merged
merged 9 commits into from
Oct 9, 2024
Merged

feat: Add support for callable defaultValue in BooleanBone #1274

merged 9 commits into from
Oct 9, 2024

Conversation

ArneGudermann
Copy link
Contributor

Fix for #1178

and add check for values in getdefaultValue.

@ArneGudermann ArneGudermann added bug(fix) Something isn't working or address a specific issue or vulnerability feature New feature or request Priority: Medium This issue may be useful, and needs some attention. labels Sep 27, 2024
@ArneGudermann ArneGudermann added this to the ViUR-core v3.7 milestone Sep 27, 2024
@ArneGudermann ArneGudermann changed the title feat: Add callable for BooleanBone feat: Add callable defaultValue for BooleanBone Sep 27, 2024
phorward
phorward requested changes Sep 30, 2024
View reviewed changes
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
phorward
phorward previously approved these changes Sep 30, 2024
View reviewed changes
@sveneberth sveneberth linked an issue Oct 1, 2024 that may be closed by this pull request
BooleanBone's defaultValue cannot be a callable #1178
Closed
sveneberth
sveneberth requested changes Oct 1, 2024
View reviewed changes
src/viur/core/bones/boolean.py Outdated Show resolved Hide resolved
src/viur/core/bones/boolean.py Outdated Show resolved Hide resolved
sveneberth
sveneberth requested changes Oct 8, 2024
View reviewed changes
src/viur/core/bones/boolean.py Outdated Show resolved Hide resolved
@phorward phorward requested a review from sveneberth October 9, 2024 09:53
@sveneberth sveneberth changed the title feat: Add callable defaultValue for BooleanBone feat: Add support for callable defaultValue in BooleanBone Oct 9, 2024
@phorward phorward merged commit 8e04095 into viur-framework:develop Oct 9, 2024
3 checks passed
@phorward phorward mentioned this pull request Oct 9, 2024
Closed
@sveneberth sveneberth deleted the feat/BooleanBone_defaultValue_callable branch October 10, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@sveneberth sveneberth sveneberth approved these changes

Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability feature New feature or request Priority: Medium This issue may be useful, and needs some attention.
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.7
Development

Successfully merging this pull request may close these issues.

BooleanBone's defaultValue cannot be a callable
3 participants
@ArneGudermann @sveneberth @phorward