Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Fix public types #7328

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

mrginglymus
Copy link
Contributor

Description

I'm trying to move to vitest browser, and have encountered a few type errors in vitests types.

Some of these may have been caught with skipLibCheck: false; I tried that but it opened up a bit of a can of worms, as many other .d.ts files contain type errors, both compiled and handwritten, along with third party deps suggesting we're missing some type packages.

This PR at least fixes the issues I've encountered in the field.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 113deac
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6791085628e6e70007c58df7
😎 Deploy Preview https://deploy-preview-7328--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit ce6af70 into vitest-dev:main Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants