fix(plugin-legacy): fix legacy plugin not working in worker context #19079
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
requested changes
Dec 27, 2024
sapphi-red
added
plugin: legacy
p3-minor-bug
Okay, I'll change it. |
sapphi-red
requested changes
Jan 7, 2025
There was a problem hiding this comment.
I guess this change will make the build application error in runtime because the legacy plugin does not transpile the worker content. I think we need to
- show an warning if a worker is used when legacy chunks are generated
- [optional] avoid injecting
__vite_legacy_guardto worker chunks so that workers work in that case
The ideal fix is to generate legacy chunks for workers. But that's hard to do.
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19073