Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 🇩🇪 added german locale link to config.ts; #14724

Merged
merged 2 commits into from
Nov 7, 2023
Merged

docs: 🇩🇪 added german locale link to config.ts; #14724

merged 2 commits into from
Nov 7, 2023

Conversation

rojadesign
Copy link
Member

Description

Adding german docs translation, following the guidelines using the vite-docs-template.


Repository: https://github.com/rojadesign/vite-docs-de

Live App: https://vite-docs-de.netlify.app/


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Oct 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@rojadesign rojadesign changed the title 🇩🇪 added german locale link to config.ts; docs: 🇩🇪 added german locale link to config.ts; Oct 22, 2023
@Shinigami92 Shinigami92 self-requested a review October 23, 2023 08:10
@Shinigami92 Shinigami92 added the documentation Improvements or additions to documentation label Oct 23, 2023
@patak-dev
Copy link
Member

Thanks a lot, @rojadesign! The work done in the translation looks good to me but I don't speak German so I'll let this one open for a bit to let others check it out. I'll contact you next week in Discord and if things look good, we can transfer the repo to the vitejs org.

Did you manage to get the ryo-cho bot setup? I don't see PRs in your repo from it.

@rojadesign
Copy link
Member Author

@patak-dev thanks for your feedback, sounds good!

Yes, I did it like the example in the contributing guide, but I also noticed there were no PRs coming in. Can you tell right away what the problem is? Otherwise I'll look into it again.

@patak-dev
Copy link
Member

Yes, I did it like the example in the contributing guide, but I also noticed there were no PRs coming in. Can you tell right away what the problem is? Otherwise I'll look into it again.

@mrcego could you help us here to see if you see a diff from the setup you did?

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patak-dev you have a go from my side

I did not check every single phrase but read through the first pages
Everything is translated and definitely in a better way then just using an AI or auto-translator 😅
This was definitely translated by a person which knows what they're doing 🙂

@patak-dev
Copy link
Member

Thanks for checking it out @Shinigami92!

@mrcego
Copy link
Member

mrcego commented Oct 23, 2023

Yes, I did it like the example in the contributing guide, but I also noticed there were no PRs coming in. Can you tell right away what the problem is? Otherwise I'll look into it again.

@mrcego could you help us here to see if you see a diff from the setup you did?

Sure, will be back later with news.

@mrcego
Copy link
Member

mrcego commented Nov 2, 2023

Look like ryu-cho config is well done.

@rojadesign I'm just curious: Have you created repo access token?

Captura web_2-11-2023_134740_github com

@rojadesign
Copy link
Member Author

Look like ryu-cho config is well done.

@rojadesign I'm just curious: Have you created repo access token?

Captura web_2-11-2023_134740_github com

Ah, that's it! No, for whatever reason I forgot. Will take care of it, thank you!

@rojadesign
Copy link
Member Author

@mrcego I tried both options using a machine user as well as the default github-action bot. Both run fine but neither create pull requests. 😞 I compared my configuration to the other translations and don't see much difference to mine. I also made sure the repo settings allow github actions to create pull requests, which was disabled before by default. I'm stuck a bit now and don't know what more I could try. Maybe @tony19 can help out since he wrote the docs template?

@mrcego
Copy link
Member

mrcego commented Nov 4, 2023

@mrcego I tried both options using a machine user as well as the default github-action bot. Both run fine but neither create pull requests. 😞 I compared my configuration to the other translations and don't see much difference to mine. I also made sure the repo settings allow github actions to create pull requests, which was disabled before by default. I'm stuck a bit now and don't know what more I could try. Maybe @tony19 can help out since he wrote the docs template?

The only thing comes to my mind is wait until some new PR is coming. That's happened before for me and, in that point, ryu-cho starts to work.

Question: what happen if you try to start job manually?

@tony19
Copy link
Contributor

tony19 commented Nov 4, 2023

@rojadesign Thanks for the translations!

I think something is wrong with your ACCESS_TOKEN. Despite the green check, your ryu-cho action is actually failing with bad credentials.

Also be aware that ryu-cho will fail to create a PR when there's a merge confict: vuejs-translations/ryu-cho#9

@rojadesign
Copy link
Member Author

rojadesign commented Nov 5, 2023

Question: what happen if you try to start job manually?

@mrcego thanks for the input! I switched to the default github actions bot (with GITHUB_TOKEN) and started ryu-cho again in debug mode, but there seems to be everything fine.

Also be aware that ryu-cho will fail to create a PR when there's a merge confict: [vuejs-translations/ryu-cho#9]
(vuejs-translations/ryu-cho#9)

@tony19 thanks for the info! Maybe there are merge conflicts, I will check this further.

Edit: An Issue was created by the github bot now 🎉 vitejs/docs-de#14

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this one in! Thanks a lot @rojadesign ❤️

@patak-dev patak-dev merged commit 3a8d5a4 into vitejs:main Nov 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants