-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 🇩🇪 added german locale link to config.ts; #14724
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Thanks a lot, @rojadesign! The work done in the translation looks good to me but I don't speak German so I'll let this one open for a bit to let others check it out. I'll contact you next week in Discord and if things look good, we can transfer the repo to the vitejs org. Did you manage to get the ryo-cho bot setup? I don't see PRs in your repo from it. |
@patak-dev thanks for your feedback, sounds good! Yes, I did it like the example in the contributing guide, but I also noticed there were no PRs coming in. Can you tell right away what the problem is? Otherwise I'll look into it again. |
@mrcego could you help us here to see if you see a diff from the setup you did? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patak-dev you have a go from my side
I did not check every single phrase but read through the first pages
Everything is translated and definitely in a better way then just using an AI or auto-translator 😅
This was definitely translated by a person which knows what they're doing 🙂
Thanks for checking it out @Shinigami92! |
Sure, will be back later with news. |
Look like ryu-cho config is well done. @rojadesign I'm just curious: Have you created repo access token? |
Ah, that's it! No, for whatever reason I forgot. Will take care of it, thank you! |
@mrcego I tried both options using a machine user as well as the default github-action bot. Both run fine but neither create pull requests. 😞 I compared my configuration to the other translations and don't see much difference to mine. I also made sure the repo settings allow github actions to create pull requests, which was disabled before by default. I'm stuck a bit now and don't know what more I could try. Maybe @tony19 can help out since he wrote the docs template? |
The only thing comes to my mind is wait until some new PR is coming. That's happened before for me and, in that point, ryu-cho starts to work. Question: what happen if you try to start job manually? |
@rojadesign Thanks for the translations! I think something is wrong with your Also be aware that |
@mrcego thanks for the input! I switched to the default github actions bot (with
@tony19 thanks for the info! Maybe there are merge conflicts, I will check this further. Edit: An Issue was created by the github bot now 🎉 vitejs/docs-de#14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this one in! Thanks a lot @rojadesign ❤️
Description
Adding german docs translation, following the guidelines using the vite-docs-template.
Repository: https://github.com/rojadesign/vite-docs-de
Live App: https://vite-docs-de.netlify.app/
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).