Fix duplicate query string params when hashbang is enabled

visionmedia · Jan 24, 2021 · 5ce2222 · 5ce2222
1 parent 4f99916
commit 5ce2222
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -157,7 +157,7 @@
       var loc = window.location;
 
       if(this._hashbang && ~loc.hash.indexOf('#!')) {
-        url = loc.hash.substr(2) + loc.search;
+        url = loc.hash.substr(2) + (~loc.hash.indexOf('?') ? '' : loc.search);
       } else if (this._hashbang) {
         url = loc.search + loc.hash;
       } else {

diff --git a/page.js b/page.js
@@ -557,7 +557,7 @@ pathToRegexp_1.tokensToRegExp = tokensToRegExp_1;
       var loc = window.location;
 
       if(this._hashbang && ~loc.hash.indexOf('#!')) {
-        url = loc.hash.substr(2) + loc.search;
+        url = loc.hash.substr(2) + (~loc.hash.indexOf('?') ? '' : loc.search);
       } else if (this._hashbang) {
         url = loc.search + loc.hash;
       } else {

diff --git a/test/support/jsdom.js b/test/support/jsdom.js
@@ -8,7 +8,7 @@ function setupJsdom(options, next) {
   function setupGlobals(window) {
     window.console = console;
     if(window.location.protocol !== 'file:')
-      window.history.replaceState(null, '', '/');
+      window.history.replaceState(null, '', '/' + options.qs || '');
     global.window = window;
     global.location = window.location;
     global.document = window.document;

diff --git a/test/tests.js b/test/tests.js
@@ -800,6 +800,30 @@
     });
   });
 
+  describei('When hashbang option enabled with base query params', function() {
+    before(function(done){
+      jsdomSupport.setup({
+        qs: '?hello=there'
+      }, done);
+    });
+
+    it('prevents duplicate query params added to hash', function(done) {
+      var count = 0;
+
+      baseRoute = function () {
+        expect(window.location.search).to.equal('?hello=there');
+        expect(window.location.hash).to.equal('#!?hello=there');
+
+        count++;
+        count === 2 && done();
+      };
+
+      page({ hashbang: true });
+      page({ hashbang: true });
+    });
+  });
+
+
   describe('Route', function() {
     before(function(done) {
       beforeTests(null, done);