-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Added System Verilog Regression Tests to GitHub Runners #2885
base: master
Are you sure you want to change the base?
Conversation
@amirarjmand93 The System Verilog regression tests do not appear to be working. There seems to be a build error with the Have you seen this error before and know how to fix it? |
I ran this test locally and the result was okay. have you tried "-DYOSYS_F4PGA_PLUGINS=ON" ? I had changed to "-DSYNLIG_SYSTEMVERILOG=ON" in nightly_testl |
What is the difference between But the NightlyTests are never being run; so I am moving it to our GitHub runners. Which of the two arguments should I give to this test? Both? |
Before Synlig , we had used F4PGA pluggin and |
The test I added is using |
I think adding this to the YML might solve the problem. I usually have tried them before making and testing a VTR with Synlig. |
d5249ad
to
56e0afe
Compare
The |
The system verilog regression tests were put into the currently not-working nightly tests. Since they are so small, putting them in the GitHub runners tests instead so they do not regress. The strong parmys test also has system verilog tests (I think); however, that test may be too large for the GitHub runners. We may consider moving that test to the SAVI workflows in the future.
56e0afe
to
f41ea8c
Compare
Lets give it a shot, but why is this necessary? |
I think this Building discrepancy might arise from some library dependency, a path conflicting with CI or a race condition between Cloning and Updating modules. but I checked and it seems no new system or Python packages are required for Synlig. (you can also check https://github.com/chipsalliance/synlig)
|
@amirarjmand93 Feel free to modify the branch anyway you like! I recommend just deleting the other tests so that just the SystemVerilog test is active if you will use the CI to test (just to save yourself time waiting for the other known working tests). If you think it is a race condition in the build script (which honestly could be the problem!), you can make the build script single threaded by setting the NUM_PROC to 1 here: |
No, thats a different list just for the coverity scan test. To turn off the other jobs you should be able to just delete the jobs from the workflow: vtr-verilog-to-routing/.github/workflows/test.yml Lines 36 to 581 in f41ea8c
So basically just delete everything under "Build:", "Format:", "UnitTests:", etc. Leaving behind just the "SystemVerilog:" job. The regular tests work slightly different from the Nightly Tests. |
Change install path
4cadfba
to
5d8eb3a
Compare
paths corrected
check synlig path
update CPU core
Run the default cmake --build
reduce build proc
The system verilog regression tests were put into the currently not-working nightly tests. Since they are so small, putting them in the GitHub runners tests instead so they do not regress.
The strong parmys test also has system verilog tests (I think); however, that test may be too large for the GitHub runners. We may consider moving that test to the SAVI workflows in the future.