Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-overlay] bump storybook to 8.5.2 #75522

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 31, 2025

Why?

Storybook 8.5 had improvement in testing a11y, good to bump for the follow up of adding tests.

Copy link
Member Author

devjiwonchoi commented Jan 31, 2025

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 31, 2025 17:41
@@ -281,7 +281,7 @@
},
"patchedDependencies": {
"[email protected]": "patches/[email protected]",
"@storybook/react@8.4.7": "patches/@storybook__react@8.4.7.patch"
"@storybook/react@8.5.2": "patches/@storybook__react@8.5.2.patch"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is going to be removed after [email protected]
PR: storybookjs/storybook#30031
Pre-release: v8.6.0-alpha.3

@devjiwonchoi devjiwonchoi requested a review from gaojude January 31, 2025 18:25
Base automatically changed from 02-01-_dev-overlay_remove_unused_addons to canary January 31, 2025 19:25
@devjiwonchoi devjiwonchoi force-pushed the 02-01-_dev-overlay_bump_storybook_to_8.5.2 branch from 24ced7e to 66826fc Compare January 31, 2025 19:26
@devjiwonchoi devjiwonchoi merged commit e86c59c into canary Jan 31, 2025
10 of 14 checks passed
@devjiwonchoi devjiwonchoi deleted the 02-01-_dev-overlay_bump_storybook_to_8.5.2 branch January 31, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants