Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(refactor): merge 'ExpressionError' and 'ExpressionError2' #554

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore(refactor): merge 'ExpressionError' and 'ExpressionError2' #554

merged 1 commit into from
Nov 13, 2023

Conversation

pront
Copy link
Member

@pront pront commented Nov 13, 2023 •
edited by jira bot
Loading

ref: #23, OPW-89

@pront pront mentioned this pull request Nov 13, 2023
Merged
@pront pront requested a review from fuchsnj November 13, 2023 18:18
pront
pront commented Nov 13, 2023
View reviewed changes
src/compiler/expression_error.rs
fn code(&self) -> usize {
0
match self {
Abort { .. } => 0,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preserving existing behavior but we might want to revisit this code.

@pront pront marked this pull request as ready for review November 13, 2023 18:18
@pront pront added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 30cabfb Nov 13, 2023
@pront pront deleted the pront/expr-error-refactoring branch November 13, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuchsnj fuchsnj fuchsnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @fuchsnj