Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(conversion): 'to_float' and 'parse_float' should share implementation #1185

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

pront
Copy link
Member

@pront pront commented Dec 9, 2024

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

If these two diverge, it opens up the path to subtle bugs for users. The to_float method is more generic and could eventually replace parse_float but there's no harm keeping both for now as long as they don't diverge in behavior.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

Partially addresses: #1120

@pront pront changed the title chore(conversion): 'to_float' and 'parse_float' should share implemen… chore(conversion): 'to_float' and 'parse_float' should share implementation Dec 9, 2024
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 9, 2024
@pront pront requested a review from jszwedko December 9, 2024 20:14
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up!

@pront pront added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 821f0d0 Dec 9, 2024
15 checks passed
@pront pront deleted the pront/to-parse-float-share-impl branch December 9, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants