fix: fix footer slot content overlapping table in Page component #5518
Conversation
frontendley
requested review from
anncwb,
vince292007 and
mynetfan
as code owners
|
WalkthroughThe change updates the Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
packages/effects/common-ui/src/components/page/page.vueOops! Something went wrong! :( ESLint: 9.19.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/effects/common-ui/src/components/page/page.vue (3)
17-19: Consider using footer height in content calculations to prevent overlap.While the component tracks both header and footer heights, the footer height (
footerHeight) is not used in the content height calculations. This could contribute to overlap issues when the footer is present.Consider updating the content height calculation to account for the footer:
const contentStyle = computed<StyleValue>(() => { if (autoContentHeight) { return { - height: `calc(var(${CSS_VARIABLE_LAYOUT_CONTENT_HEIGHT}) - ${headerHeight.value}px)`, + height: `calc(var(${CSS_VARIABLE_LAYOUT_CONTENT_HEIGHT}) - ${headerHeight.value}px - ${footerHeight.value}px)`, overflowY: shouldAutoHeight.value ? 'auto' : 'unset', }; } return {}; });Also applies to: 34-44
92-98: LGTM! The removal of absolute positioning should fix the overlap.The removal of
absolute bottom-0 left-0 right-0classes is the correct approach to fix the footer overlap issue, as it keeps the footer in the normal document flow.Consider adding a wrapper div with
relativeclass around the footer to maintain proper stacking context if needed:+ <div class="relative"> <div v-if="$slots.footer" ref="footerRef" :class="cn('bg-card align-center flex px-6 py-4', footerClass)" > <slot name="footer"></slot> </div> + </div>
51-52: Consider adding flex layout for better content distribution.The component structure is good, but using flex layout could provide better control over content distribution and prevent overlap issues.
Consider updating the root container to use flex layout:
- <div class="relative"> + <div class="relative flex min-h-full flex-col"> <!-- header --> - <div :class="cn('h-full p-4', contentClass)" :style="contentStyle"> + <div :class="cn('flex-1 p-4', contentClass)" :style="contentStyle"> <slot></slot> </div> <!-- footer --> </div>Also applies to: 88-90
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/effects/common-ui/src/components/page/page.vue(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: post-update (windows-latest)
- GitHub Check: post-update (ubuntu-latest)
Description
related to the issue #5494
Type of change
Please delete options that are not relevant.
Checklist
pnpm run docs:devcommand.pnpm test.feat:,fix:,perf:,docs:, orchore:.Summary by CodeRabbit