fix: ant tag icon default style

[mynetfan]

Description

修复 Antd 的 Tag 组件图标插槽样式不正确的问题

fix: #5472

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• Style

  • Refined button and tag styling for more precise visual presentation.
  • Introduced a new tag style with improved spacing for icons and text.

• New Features

  • Integrated the ChevronDown icon into button and tag elements.
  • Enhanced layout alignment in tooltip examples, offering a cleaner, more balanced interface.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 834ae67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/styles/src/antd/index.css

Oops! Something went wrong! :(

ESLint: 9.17.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

playground/src/views/examples/tippy/index.vue

Oops! Something went wrong! :(

ESLint: 9.17.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/node_modules/@vben/eslint-config/dist/index.mjs' imported from /eslint.config.mjs
at finalizeResolution (node:internal/modules/esm/resolve:257:11)
at moduleResolve (node:internal/modules/esm/resolve:914:10)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

Walkthrough

The pull request refines CSS selectors in the Ant Design Vue styles and updates a Vue example. In the CSS file, the selectors for svg elements in .ant-btn have been changed to target only direct children, and a new .ant-tag class with similar specificity is introduced. In the Vue file, new imports for the ChevronDown icon and the Tag component have been added; additionally, Flex layout properties are updated and icon slots have been integrated into both Button and Tag components.

Changes

File	Change Summary
packages/styles/src/antd/index.css	Updated selector specificity in .ant-btn (from svg to > svg and svg + span to > svg + span); introduced new .ant-tag class with similar direct-child style rules.
playground/src/views/examples/tippy/index.vue	Added imports for ChevronDown from @vben/icons and Tag from ant-design-vue; updated Flex component with align="center"; integrated icon slots into Button and Tag.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure Tag's icon slot and text align on the same line (#5472)	✅

Possibly related PRs

• fix: antd button icon style #5421: Refines CSS selectors for svg elements within the .ant-btn class, which is closely related to these updates.
• fix: improve ant design button icon style #4520: Addresses similar style modifications in .ant-btn to improve icon alignment.

Suggested labels

bug

Suggested reviewers

• anncwb
• vince292007

Poem

Hop, hop, I scurry in the code meadow,
Tweaking selectors so icons properly glow.
With direct-child care and new tags in sight,
I align the icon and text just right.
Celebrating each bug fixed with a joyful hop!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a832edc and 834ae67.

📒 Files selected for processing (2)

• packages/styles/src/antd/index.css (1 hunks)
• playground/src/views/examples/tippy/index.vue (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: Test (windows-latest)
• GitHub Check: Test (ubuntu-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (windows-latest)
• GitHub Check: Lint (ubuntu-latest)
• GitHub Check: post-update (ubuntu-latest)
• GitHub Check: Check (windows-latest)
• GitHub Check: Check (ubuntu-latest)
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (6)

packages/styles/src/antd/index.css (2)

16-22: LGTM! Improved selector specificity.

The change to use direct child selectors (>) for SVG elements in buttons is a good practice. It prevents unintended styling of nested SVGs and makes the component styling more predictable.

---

25-33: LGTM! Well-structured tag icon styling.

The new .ant-tag class follows the same pattern as buttons but with an appropriate 4px margin, which maintains visual hierarchy. This directly addresses the PR objective of fixing the tag icon default style.

playground/src/views/examples/tippy/index.vue (4)

7-7: LGTM! Required imports added.

The new imports for ChevronDown icon and Tag component are properly organized and necessary for the implementation.

Also applies to: 9-9

---

258-258: LGTM! Improved flex alignment.

The addition of align="center" to the Flex component ensures proper vertical alignment of buttons and tags.

---

281-284: LGTM! Well-structured button icon implementation.

The icon template follows Ant Design Vue's slot pattern and ensures consistent sizing with the size-4 class.

---

286-292: LGTM! Consistent tag implementation.

The tag implementation follows the same pattern as the button, maintaining consistency in icon sizing and slot usage.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.