-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Support for SQL Server Dialect #68
Conversation
Hey @dylel, thank you so much for the pull request! I'll keep my eyes peeled for when the PR gets merged on Kysely's side. Once that's done we can add a test script to validate that the types are correct. I'm assuming this is the PR you're talking about: kysely-org/kysely#595 |
Yeah that's the one I was referring to, anything else you would like me to do so this can be merged? |
As I say I'd prefer not merging this before I can validate that the type map is totally correct. If you add a changeset using |
No worries, i've just installed it straight from the pr for the time being
|
Kysely has released sql server support. Would be great to see this PR merged and released! |
Yes please. For the record: I already use this PR as a patch in production. |
Hey there, sorry for the delay. I'll merge this now. |
Any updates? |
Not entirely sure how the type mapping was supposed to work but i've added a mapping that seems to work correctly. Can't add tests for kysely yet as the sql server dialect hasn't been merged.