Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Support for SQL Server Dialect #68

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

dylel
Copy link
Contributor

@dylel dylel commented Aug 22, 2023

Not entirely sure how the type mapping was supposed to work but i've added a mapping that seems to work correctly. Can't add tests for kysely yet as the sql server dialect hasn't been merged.

@dylel dylel requested a review from valtyr as a code owner August 22, 2023 08:29
@dylel dylel mentioned this pull request Aug 22, 2023
@valtyr
Copy link
Owner

valtyr commented Aug 22, 2023

Hey @dylel, thank you so much for the pull request! I'll keep my eyes peeled for when the PR gets merged on Kysely's side. Once that's done we can add a test script to validate that the types are correct.

I'm assuming this is the PR you're talking about: kysely-org/kysely#595

@dylel
Copy link
Contributor Author

dylel commented Aug 23, 2023

Yeah that's the one I was referring to, anything else you would like me to do so this can be merged?

@valtyr
Copy link
Owner

valtyr commented Aug 23, 2023

As I say I'd prefer not merging this before I can validate that the type map is totally correct. If you add a changeset using yarn changeset I can generate a snapshot release that you and others can use in the meantime.

@dylel
Copy link
Contributor Author

dylel commented Sep 2, 2023

No worries, i've just installed it straight from the pr for the time being

pnpm install valtyr/prisma-kysely#refs/pull/68/head

@fehnomenal
Copy link
Contributor

Thank you for this PR, @dylel.

The kysely PR is merged but not yet released @valtyr. Can we still progress on this PR?

@drew-marsh
Copy link

Kysely has released sql server support. Would be great to see this PR merged and released!

@fehnomenal
Copy link
Contributor

Yes please. For the record: I already use this PR as a patch in production.

@valtyr
Copy link
Owner

valtyr commented Jan 16, 2024

Hey there, sorry for the delay. I'll merge this now.

@jrvgr
Copy link

jrvgr commented Jan 22, 2024

Any updates?

@valtyr valtyr merged commit 4526321 into valtyr:main Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants