Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust testUnexpectedSymbolsInput for unfiltered symbols #17

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix: Adjust testUnexpectedSymbolsInput for unfiltered symbols #17

merged 1 commit into from
Jan 11, 2024

Conversation

shatterproof
Copy link
Contributor

The filtering of provided symbols to useSymbols was removed with commit 914f0da and testUnexpectedSymbolsInput needed to be updated to reflect that in order to prevent random cases of failed tests.

Since a symbol can be any character now after that commit, the test was updated to confirm only symbols from the provided character set are used.

This begs the question though if useSymbols should still at least filter out alphanumeric characters since they are already covered by the other methods useLower, useUpper, and useNumbers?

@valorin
Copy link
Owner

valorin commented Jan 11, 2024

Ah, nice catch. I forgot about that test, and clearly missed the failing tests.

I think I prefer to keep it completely open. Anything can be considered a symbol.

@valorin valorin merged commit 33918e5 into valorin:main Jan 11, 2024
8 checks passed
@shatterproof shatterproof deleted the symbols branch January 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants