Addding homework_04 #111
Open
Addding homework_04 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvvrachev
requested changes
Feb 27, 2022
Comment on lines
1
to
34
| name: Pylint | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| paths: | ||
| - homework_04/05_viktoriya_vasileva/** | ||
| pull_request: | ||
| branches: [ main ] | ||
| paths: | ||
| - homework_04/05_viktoriya_vasileva/** | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9"] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| - name: Analysing the code with pylint | ||
| run: | | ||
| cd homework_04 | ||
| cd 05_viktoriya_vasileva | ||
| pylint circles.py | ||
| pylint test_circles.py |
There was a problem hiding this comment.
This file needs to be in .github/workflows so the checks actually run. That way github does not recognise the yaml file as a workflow so it does not run neither on push nor pull request.
There was a problem hiding this comment.
You also do not have a "run" which runs the tests. You need to add that as well.
|
|
||
| def line(self, point): | ||
| """ | ||
| Find the length og the line |
DeniBademi
requested changes
Feb 27, 2022
Comment on lines
1
to
34
| name: Pylint | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| paths: | ||
| - homework_04/05_viktoriya_vasileva/** | ||
| pull_request: | ||
| branches: [ main ] | ||
| paths: | ||
| - homework_04/05_viktoriya_vasileva/** | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: ["3.8", "3.9"] | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements.txt | ||
| - name: Analysing the code with pylint | ||
| run: | | ||
| cd homework_04 | ||
| cd 05_viktoriya_vasileva | ||
| pylint circles.py | ||
| pylint test_circles.py |
Vicktoria853
force-pushed
the
05_viktoriya_vasileva
branch
from
8c8a476 to
d5d9fcc
Compare
Vicktoria853
requested review from
DeniBademi and
a user
and removed request for
DeniBademi
ghost
reviewed
Mar 15, 2022
| @@ -0,0 +1,34 @@ | |||
| name: Pylint | |||
There was a problem hiding this comment.
The convention here should be: Homework 04 - xx Firstname Lastname
Furthermore, this file should be in the folder .github/workflows.
Comment on lines
+30
to
+34
| run: | | ||
| cd homework_04 | ||
| cd 05_viktoriya_vasileva | ||
| pylint circles.py | ||
| pylint test_circles.py |
There was a problem hiding this comment.
After this you need another section for running the unit tests. For your case, this is:
- name: Run All Unit Tests
run: |
cd homework_04/05_viktoriya_vasileva
pytest
I will just comment without accepting or returning the request, try to fix these problems, if you want help, ask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.