Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP, CI] codecov add Conda environment CI coverage reports #2239

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

icfaust
Copy link
Contributor

@icfaust icfaust commented Jan 2, 2025

Description

Add a comprehensive description of proposed changes

List associated issue number(s) if exist(s): #6 (for example)

Documentation PR (if needed): #1340 (for example)

Benchmarks PR (if needed): IntelPython/scikit-learn_bench#155 (for example)


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
github 83.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@icfaust icfaust force-pushed the dev/add_azp_codecov branch from a95a281 to 31a9709 Compare January 4, 2025 14:07
@david-cortes-intel
Copy link
Contributor

Looks like it's missing some installs:

2025-01-04T14:54:52.9615216Z debug - 2025-01-04 14:54:52,955 -- Selected preparation plugins --- {"selected_plugins": ["<class 'codecov_cli.plugins.xcode.XcodePlugin'>", "<class 'codecov_cli.plugins.gcov.GcovPlugin'>", "<class 'codecov_cli.plugins.pycoverage.Pycoverage'>"], "cli_config": {}}
2025-01-04T14:54:52.9616013Z debug - 2025-01-04 14:54:52,955 -- Running preparation plugin: <class 'codecov_cli.plugins.xcode.XcodePlugin'>
2025-01-04T14:54:52.9616705Z debug - 2025-01-04 14:54:52,955 -- Running xcode plugin...
2025-01-04T14:54:52.9787222Z warning - 2025-01-04 14:54:52,971 -- xcrun is not installed or can't be found.
2025-01-04T14:54:52.9788181Z debug - 2025-01-04 14:54:52,971 -- Running preparation plugin: <class 'codecov_cli.plugins.gcov.GcovPlugin'>
2025-01-04T14:54:52.9788815Z debug - 2025-01-04 14:54:52,971 -- Running gcov plugin...
2025-01-04T14:54:53.0454153Z warning - 2025-01-04 14:54:53,033 -- No gcov data found.
2025-01-04T14:54:53.0455777Z debug - 2025-01-04 14:54:53,033 -- Running preparation plugin: <class 'codecov_cli.plugins.pycoverage.Pycoverage'>
2025-01-04T14:54:53.0633472Z warning - 2025-01-04 14:54:53,049 -- coverage.py is not installed or can't be found.
2025-01-04T14:54:53.0635009Z debug - 2025-01-04 14:54:53,049 -- Collecting relevant files
2025-01-04T14:54:53.1908488Z info - 2025-01-04 14:54:53,190 -- Found 1 coverage files to report
2025-01-04T14:54:53.1911271Z info - 2025-01-04 14:54:53,190 -- > D:\a\1\s\coverage.json
2025-01-04T14:54:53.2238213Z debug - 2025-01-04 14:54:53,221 -- Selected uploader to use: <class 'codecov_cli.services.upload.upload_sender.UploadSender'>
2025-01-04T14:54:53.2377521Z debug - 2025-01-04 14:54:53,236 -- Sending upload request to Codecov
2025-01-04T14:54:53.9988611Z info - 2025-01-04 14:54:53,995 -- Process Upload complete
2025-01-04T14:54:53.9990118Z debug - 2025-01-04 14:54:53,995 -- Upload result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 400', params={}, description='{\"message\":\"Repository not found\"}\\n'), warnings=[], status_code=400, text='{\"message\":\"Repository not found\"}\\n')"}
2025-01-04T14:54:53.9991030Z error - 2025-01-04 14:54:53,995 -- Upload failed: {"message":"Repository not found"}
2025-01-04T14:54:54.5197429Z ##[error]Cmd.exe exited with code '1'.
2025-01-04T14:54:54.5549346Z ##[section]Finishing: Upload to codecov

@icfaust
Copy link
Contributor Author

icfaust commented Jan 7, 2025

Don't worry, thats okay. Same warnings are published on the github implementation, there are some internal conversion utilities of coverage/gcov/xcode files into proper formats which is done manually for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants