Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding read-only permission to all jobs in the CI flow to ensure minimum required access #1300

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

timmiesmith
Copy link
Contributor

Description

The change is being made to bring the repo into compliance with the recommended best practice of enforcing the policy of least privilege. See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions for the details.

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@pavelkumbrasev @isaevil

@timmiesmith timmiesmith requested a review from omalyshe January 23, 2024 19:24
Copy link
Contributor

@omalyshe omalyshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timmiesmith timmiesmith merged commit 144b184 into master Jan 23, 2024
19 checks passed
@timmiesmith timmiesmith deleted the timmiesm/set-workflow-permissions branch January 23, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants