fix(join)!: preserve normalized unc paths #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielroe do you mind taking a look on this? 🙏🏼 |
|
not at all! will have a look when I'm back at my computer (I've been travelling today) |
danielroe
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #178 (#178 (comment))
Even though
normalizeis UNC aware,joinutility blindly strips the leading UNC indicator with a final replacement.This PR changes
joinimplementation to avoid global regex (normalize finally takes care of proper normalization).Note: While all existing tests pass, this is a potential behavior change
Note: This PR does not add URL compatibility to path utils as it needs changes to more utils and it is out of scope / non goal.