feat(table): support align option
#37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage ? 97.10%
=======================================
Files ? 11
Lines ? 484
Branches ? 139
=======================================
Hits ? 470
Misses ? 12
Partials ? 2 ☔ View full report in Codecov by Sentry. |
pi0
reviewed
Nov 27, 2024
src/render.ts
Outdated
| @@ -140,6 +140,12 @@ export function codeBlock( | |||
| * @group render_utils | |||
| */ | |||
| export function table(table: { rows: string[][]; columns: string[] }): string { | |||
| const columnLength = table.columns.length; | |||
| if (table.rows.some((row) => row.length !== columnLength)) { | |||
There was a problem hiding this comment.
Some rows might have empty leading values in their cells so this can happen
There was a problem hiding this comment.
ok, you are right. But if this may cause mistakes that developers are not easy to detect.
|
I made some new changes. |
StrivingRabbit
changed the title
pi0
changed the title
align option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create md table.
Columns and rows may need to be the same length？Or is this what you expected?