Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22921 Add windows script doing jar extraction #3325

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Jan 6, 2025

The longer term fix would be to do it in Python, which would be cross-platform.

But that would need some "foundations":

  • where to put all the scripts
  • support modules (logging, exec, file system manipulation)

Checklist

  • Required: Issue filed: ICU-22921
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@mihnita mihnita requested a review from markusicu January 6, 2025 22:00
@mihnita mihnita requested a review from echeran January 8, 2025 17:44
@mihnita mihnita assigned echeran and unassigned markusicu Jan 8, 2025
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit of a stretch for the "docs minor fixes" ticket, but... ok.

Also mostly-rs...lgtm.

@rp9-next @eggrobin FYI

@mihnita
Copy link
Contributor Author

mihnita commented Jan 8, 2025

It's a bit of a stretch for the "docs minor fixes" ticket, but... ok.

ACK.
Thank you.

@mihnita mihnita merged commit ba5cf31 into unicode-org:main Jan 8, 2025
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants