Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22991 Reduce sizeof(Calendar) from 624 to 488 bytes #3299

Closed
wants to merge 4 commits into from

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Dec 12, 2024

Reduce memory requirement for Calendar object by using bit fields

Before the PR, sizeof(Calendar) is 624 bytes, this reduce to 488 bytes

Checklist

  • Required: Issue filed: ICU-22991
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang FrankYFTang added the incomplete Needs work; do not approve/merge as is. label Dec 12, 2024
@FrankYFTang
Copy link
Contributor Author

We need to talk to ICU TC about this since this PR change some protected member data and methods.

@FrankYFTang FrankYFTang changed the title ICU-22991 Reduce sizeof(Calendar) from 624 to 560 bytes ICU-22991 Reduce sizeof(Calendar) from 624 to 488 bytes Dec 12, 2024
@FrankYFTang
Copy link
Contributor Author

The changes investigated by this PR were already merged by other PR. Close this.

@FrankYFTang FrankYFTang closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete Needs work; do not approve/merge as is.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant