don't fail if status is System try again

unicef · Feb 3, 2025 · 2ceae95 · 2ceae95
1 parent c7b16c4
commit 2ceae95
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/hope_payment_gateway/apps/fsp/moneygram/client.py b/src/hope_payment_gateway/apps/fsp/moneygram/client.py
@@ -152,8 +152,23 @@ def prepare_transaction(self, base_payload):
     def create_transaction(self, base_payload, update=True):
         """Create a transaction to MoneyGram."""
         endpoint = "/disbursement/v1/transactions"
-        transaction_id, payload = self.prepare_transaction(base_payload)
-        response = self.perform_request(endpoint, transaction_id, payload, "post")
+        try:
+            transaction_id, payload = self.prepare_transaction(base_payload)
+            response = self.perform_request(endpoint, transaction_id, payload, "post")
+        except (PayloadMissingKeyError, ValueError, TypeError) as e:
+            record_code = base_payload["payment_record_code"]
+            pr = PaymentRecord.objects.get(
+                record_code=record_code,
+                parent__fsp__vendor_number=config.MONEYGRAM_VENDOR_NUMBER,
+            )
+            flow = PaymentRecordFlow(pr)
+            flow.fail()
+            pr.message = e.args[0]
+            pr.save()
+            response = Response(
+                {"errors": [{"code": "validation_error", "message": e.args[0]}]},
+                status=HTTP_400_BAD_REQUEST,
+            )
 
         if update and response.status_code == 200:
             self.post_transaction(response, base_payload)

diff --git a/src/hope_payment_gateway/config/fragments/constance.py b/src/hope_payment_gateway/config/fragments/constance.py
@@ -20,7 +20,7 @@
         "T4840;T4900;T4977;T4989;T4989;T5499;T5500;T5519;T5522;T6216;T6332;T6750;T6791;T8004;T8881;T9103;T9133;T9980;"
         "U0004;U0006;U0007;U0119;U2400;U2402;U2520;U2521;U2535;U2539;U2540;U7777;U8001;U8004;U8010;U8011;U8100;U8101;"
         "U8200;U8201;U9001;U9002;U9010;U9011;U9013;U9015;U9016;U9020;U9021;U9022;U9023;U9024;U9025;U9081;M0006;T6253;"
-        "NONE;E9248;T0371;T8002;T5499;U0051;T5552",
+        "NONE;E9248;T0371;T8002;T5499;U0051;T5552;E9256",
         "Error codes which depend on WU",
         str,
     ),