-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harvard Tech for Social Good: Data Warehouse Integration for Importing SDMX Format Related Tables #354
base: main
Are you sure you want to change the base?
Conversation
testing making PR from charliechen branch to dev-t4sg
…ce done implementing. look at database-test-app/src/update_dsd for continuing work and TestUpdateDSD for testing.
- Currently testing app is broken with the new input - New input has not been debugged (some results may be invalid) - Documentation is still in progress - Resulting output is a dictionary with each key having an array of objects, and each object having an id, description and name, description is sometimes blank depending on the label
- Able to receive agency, dataflow, dataflow_version, and an object with dimensions - Will output updated_dimensions, api_response, api_url, sdmx_implementation
- Abstracted away components - Added helper functions - Organized styles
Charlie/midpoint updates
…es, cleaned up code
Charlie/mvp0 final
Charlie/mvp0 final
@@ -0,0 +1,33 @@ | |||
# Generated by Django 3.2.16 on 2024-11-02 15:14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this as latest code already handle this (please pull main branch)
@@ -26,6 +26,7 @@ import { EmbedConfig } from "../../utils/embed"; | |||
import { LEFT, RIGHT } from "../../components/ToggleButton"; | |||
import { ProjectOverview } from "./Toolbars"; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this
@@ -35,6 +36,7 @@ export default function Dashboard({ children }) { | |||
user_permission | |||
} = useSelector(state => state.dashboard.data); | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this
.gitignore
Outdated
@@ -25,6 +25,7 @@ django_project/frontend/package-lock.json | |||
django_project/frontend/webpack-stats.dev.json | |||
django_project/frontend/webpack-stats.prod.json | |||
django_project/geosight/georepo/api/mock/create_responses.py | |||
django_project/frontend/package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this or the package json is not found
django_project/package.json
Outdated
@@ -0,0 +1,14 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is this file
django_project/package-lock.json
Outdated
@@ -0,0 +1,13 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is this file
@@ -49,8 +49,8 @@ import { updateDataWithSetState } from "../../utils"; | |||
*/ | |||
export const SDMXIndicatorValue = forwardRef( | |||
({ | |||
data, setData, files, setFiles, indicatorList |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this (as no actual changes here)
@@ -0,0 +1,10 @@ | |||
// config.js | |||
const API_URLS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ee need to make the domain an input
So user can use other sdmx api to handle this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I believe our current implementation only handles one sdmx implementation (if that's what you mean). So, we don't really account for multiple sdmx implementations (which probably have different API behavior). We can include a "dummy" variable for the sdmx implementation though, if that's what you want. Alternatively, once we include multiple api implementations, we can easily add that to the function
deployment/docker/Dockerfile
Outdated
# For Mac M1/M2 use the below code | ||
# FROM --platform=amd64 ubuntu:20.04 AS prod | ||
FROM --platform=amd64 ubuntu:20.04 AS prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this (As it is for local)
Addressing Irwan's Changes
…taset.py per review feedback
Harvard Tech for Social Good: Added Data Warehouse integration for importing SDMX Format Related Tables
DsdComponents
Stores the general frontend components and the functions that call Data Warehouse
DimensionDropdown.jsx
Parameters:
Returns:
DropdownSection.jsx
Parameters:
Returns:
DsdForm.jsx
Parameters:
request
, the request/response payload state variableReturns:
dsdFunctions.jsx
propagateAgencyOptions
Outputs:
A list of agencies, each specifying
restrictDataflowOptions
Inputs:
Outputs:
A list of dataflow objects, where each object contains:
If agencyParam is not provided, an empty list is returned.
updateDsd
Inputs:
Outputs:
An object containing:
If an error occurs, an object with an error property is returned.
propagateDataflowVersions
Inputs:
Outputs:
updateDimensions
Inputs:
Outputs:
An object containing:
If an error occurs, an object with an error property is returned.
fetchFunctions.jsx
fetchAgencies
Inputs:
fetchDataflows
Inputs:
fetchDataflowVersions
Inputs:
fetchDimensions
Inputs:
fetchDsd
Inputs: