Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/yarn-workspaces #103

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .eslintignore

This file was deleted.

11 changes: 9 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
module.exports = {
extends: 'airbnb-base',
ignorePatterns: [
'**/dist',
'**/test',
'**/estatico-eslint/test/fixtures/main.js',
'**/estatico-webpack/test/fixtures/async.js',
'**/estatico-boilerplate/src',
],
rules: {
'import/no-extraneous-dependencies': 'off',
'import/no-unresolved': 'off'
}
'import/no-unresolved': 'off',
},
};
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
node_modules
dist
lerna-debug.log
yarn-error.log
.DS_Store
17 changes: 8 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
language: node_js

node_js:
- "14"
Copy link
Collaborator

@lbsonley lbsonley Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should consider adding multiple node versions here. Travis will do a build for each version listed. I think we should keep all LTS versions of node here. This way we can say we support LTS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's go for 12.x and 14.x

cache:
directories:
- node_modules

cache: yarn

script:
- lerna bootstrap --loglevel=verbose
- yarn install
- yarn test
# https://github.com/travis-ci/travis-ci/issues/8836#issuecomment-356362524
sudo: required

before_install:
- sudo apt-get update
- sudo apt-get install graphicsmagick
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to install graphicsmagick for the image optimization task.

- npm i -g yarn
- curl -o- -L https://yarnpkg.com/install.sh | bash
- export PATH="$HOME/.yarn/bin:$PATH"
22 changes: 0 additions & 22 deletions lerna.json

This file was deleted.

36 changes: 16 additions & 20 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,29 +1,25 @@
{
"name": "estatico-nou",
"description": "The static site generator for frontend engineers.",
"private": true,
"devDependencies": {
"@commitlint/cli": "^7.2.1",
"@commitlint/config-conventional": "^7.1.2",
"eslint": "^4.19.1",
"eslint-config-airbnb-base": "^12.1.0",
"eslint-plugin-import": "^2.11.0",
"husky": "^1.1.2",
"lerna": "^3.4.3"
},
"scripts": {
"bootstrap": "lerna bootstrap",
"clean": "lerna clean",
"lint": "eslint --fix \"{,**,**/**}*.js\"",
"netlify": "lerna bootstrap && lerna exec --scope @unic/estatico-boilerplate -- npm run netlify",
"release": "lerna publish",
"test": "lerna exec -- yarn test",
"update": "yarn outdated && lerna exec -- yarn outdated"
"workspaces": [
"packages/*"
],
"dependencies": {
"@commitlint/cli": "^11.0.0",
"@commitlint/config-conventional": "^11.0.0",
"eslint": "^7.18.0",
"eslint-config-airbnb-base": "^14.2.1",
"husky": "^4.3.8"
},
"husky": {
"hooks": {
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
}
},
"workspaces": [
"packages/*"
]
"scripts": {
"lint": "eslint . --fix",
"test": "yarn workspaces run test",
"update": "yarn upgrade-interactive --latest"
}
}
Loading