-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/yarn-workspaces #103
Open
robinloeffel
wants to merge
10
commits into
develop
Choose a base branch
from
feature/yarn-workspaces
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f3c22a9
chore: clean up eslint config
3c14a70
chore: remove lerna file from ignore
3dc88d1
chore: remove lerna config
f638001
feat: switch out lerna for yarn workspaces
fa765ef
Merge remote-tracking branch 'origin/develop' into feature/yarn-works…
5860238
chore: adapt eslintrc
0d8eef7
chore: add macos sys file to gitignore
914197d
chore: fix yarn update run script
6ad5e77
feat: load yarn more elegantly on travis
cb0fdef
chore: always use latest version of yarn, use yarn's cache
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,14 @@ | ||
module.exports = { | ||
extends: 'airbnb-base', | ||
ignorePatterns: [ | ||
'**/dist', | ||
'**/test', | ||
'**/estatico-eslint/test/fixtures/main.js', | ||
'**/estatico-webpack/test/fixtures/async.js', | ||
'**/estatico-boilerplate/src', | ||
], | ||
rules: { | ||
'import/no-extraneous-dependencies': 'off', | ||
'import/no-unresolved': 'off' | ||
} | ||
'import/no-unresolved': 'off', | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
node_modules | ||
dist | ||
lerna-debug.log | ||
yarn-error.log | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,14 @@ | ||
language: node_js | ||
|
||
node_js: | ||
- "14" | ||
cache: | ||
directories: | ||
- node_modules | ||
|
||
cache: yarn | ||
|
||
script: | ||
- lerna bootstrap --loglevel=verbose | ||
- yarn install | ||
- yarn test | ||
# https://github.com/travis-ci/travis-ci/issues/8836#issuecomment-356362524 | ||
sudo: required | ||
|
||
before_install: | ||
- sudo apt-get update | ||
- sudo apt-get install graphicsmagick | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we still need to install graphicsmagick for the image optimization task. |
||
- npm i -g yarn | ||
- curl -o- -L https://yarnpkg.com/install.sh | bash | ||
- export PATH="$HOME/.yarn/bin:$PATH" |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,25 @@ | ||
{ | ||
"name": "estatico-nou", | ||
"description": "The static site generator for frontend engineers.", | ||
"private": true, | ||
"devDependencies": { | ||
"@commitlint/cli": "^7.2.1", | ||
"@commitlint/config-conventional": "^7.1.2", | ||
"eslint": "^4.19.1", | ||
"eslint-config-airbnb-base": "^12.1.0", | ||
"eslint-plugin-import": "^2.11.0", | ||
"husky": "^1.1.2", | ||
"lerna": "^3.4.3" | ||
}, | ||
"scripts": { | ||
"bootstrap": "lerna bootstrap", | ||
"clean": "lerna clean", | ||
"lint": "eslint --fix \"{,**,**/**}*.js\"", | ||
"netlify": "lerna bootstrap && lerna exec --scope @unic/estatico-boilerplate -- npm run netlify", | ||
"release": "lerna publish", | ||
"test": "lerna exec -- yarn test", | ||
"update": "yarn outdated && lerna exec -- yarn outdated" | ||
"workspaces": [ | ||
"packages/*" | ||
], | ||
"dependencies": { | ||
"@commitlint/cli": "^11.0.0", | ||
"@commitlint/config-conventional": "^11.0.0", | ||
"eslint": "^7.18.0", | ||
"eslint-config-airbnb-base": "^14.2.1", | ||
"husky": "^4.3.8" | ||
}, | ||
"husky": { | ||
"hooks": { | ||
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS" | ||
} | ||
}, | ||
"workspaces": [ | ||
"packages/*" | ||
] | ||
"scripts": { | ||
"lint": "eslint . --fix", | ||
"test": "yarn workspaces run test", | ||
"update": "yarn upgrade-interactive --latest" | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should consider adding multiple node versions here. Travis will do a build for each version listed. I think we should keep all LTS versions of node here. This way we can say we support
LTS
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed, let's go for
12.x
and14.x