-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Show upload progress for dropped files in the Media Library #18148
Conversation
…mick the OpenAPI generator
…cate upload status
… able to show the progress in percent
Perhaps it is just me or would a simple progress bar look more clean/slick .. imagine uploading 20 files :) I like something like these examples: Perhaps just show an overlay with progress and refresh view + tree when finished? |
@bjarnef Thanks for your input. I like the Vaadin component. We went another way at some point and tried to hide the dropzone UI a bit unless you use it. I agree that some overlay could persist as the files are uploading or shown above the collection view. Code-wise, it would also be more slick, as we wouldn't have to force these placeholder items into the collection view. I think it is out-of-scope to change the whole UI in this PR, but I would certainly invite to a discussion in the area. Would you mind if I convert your comment into a discussion? |
@iOvergaard created a discussion here: #18155 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out, it works really well! 🚀
As for any cosmetic tweaks, we can see how the discussion goes and iterate on that.
Description
With the change from Fetch to XHR in #18113 we now can follow along on the upload progress on dropped files on the dropzone in the Media Library. This PR aims to wire up the code from the upload function all the way back to the temporary file badge.
Changes
onProgress
->progress()
through the progressItems and into the media collection grid view to show on the temporary file badgexhrRequest
so it no longer accepts a controller host - it will now use the OpenApi object to infer the token directly instead allowing it to better mimic the generated ts client AND work with the mock server (this hasn't been released yet, so should be safe to break)Screenshare.-.2025-01-28.5_03_11.PM.mp4
Note: The error shown when a file is too large is going to be addressed in another PR.
How to test