Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted Notification Banner Border Radius and On Click Color. #4181

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

ochi12
Copy link
Contributor

@ochi12 ochi12 commented Dec 13, 2024

Current Implementation
BORDER RADIUS
BORDER RADIUS + ON CLICK
My Implementation
BORDER RADIUS
BORDER RADIUS + ON CLICK

radius: 12px (base on a gtk window).

onclick-color: bg_color at 8 percent. I increased it from 4 to 8 because 4% is actually too dark. The reason behind the appearance of that overly bright on click color is the it uses the default upstream on click color. I solved it by adding a
!important to the background-color property.

Fixes #4082

@Feichtmeier
Copy link
Member

Very nice thank you!
Just one thing, did you check the light theme?

@ochi12
Copy link
Contributor Author

ochi12 commented Dec 13, 2024

Very nice thank you! Just one thing, did you check the light theme?

Oh I thought the color problem is only for the dark theme ok I'll check it later.

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@3v1n0 3v1n0 merged commit 4b94750 into ubuntu:master Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark Shell Notifications have too bright onClick color
4 participants