Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default time encoder #391

Merged
merged 1 commit into from
Jan 22, 2025
Merged

default time encoder #391

merged 1 commit into from
Jan 22, 2025

Conversation

zachcheu
Copy link
Collaborator

zap logger requires a encode timer. We should supply a default when operating without a config.

@zachcheu zachcheu self-assigned this Jan 22, 2025
@zachcheu zachcheu requested a review from xinlongz1 January 22, 2025 17:32
@xinlongz1 xinlongz1 merged commit cfcda81 into master Jan 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinlongz1 xinlongz1 xinlongz1 approved these changes

Assignees

@zachcheu zachcheu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachcheu @xinlongz1