HTTPS for registry requests

uber · Jan 26, 2025 · 38a48a7 · 38a48a7
1 parent 1ead1d8
commit 38a48a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/lib/backend/registrybackend/blobclient.go b/lib/backend/registrybackend/blobclient.go
@@ -4,7 +4,7 @@
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
-//     http://www.apache.org/licenses/LICENSE-2.0
+//	http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ -52,8 +52,8 @@ func (f *blobClientFactory) Create(
 	return NewBlobClient(config, stats)
 }
 
-const _layerquery = "http://%s/v2/%s/blobs/sha256:%s"
-const _manifestquery = "http://%s/v2/%s/manifests/sha256:%s"
+const _layerquery = "https://%s/v2/%s/blobs/sha256:%s"
+const _manifestquery = "https://%s/v2/%s/manifests/sha256:%s"
 
 // BlobClient stats and downloads blob from registry.
 type BlobClient struct {

diff --git a/lib/backend/testfs/client.go b/lib/backend/testfs/client.go
@@ -4,7 +4,7 @@
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
-//     http://www.apache.org/licenses/LICENSE-2.0
+//	http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ -85,8 +85,7 @@ func (c *Client) Stat(namespace, name string) (*core.BlobInfo, error) {
 	if err != nil {
 		return nil, fmt.Errorf("pather: %s", err)
 	}
-	resp, err := httputil.Head(
-		fmt.Sprintf("https://%s/files/%s", c.config.Addr, p))
+	resp, err := httputil.Head(fmt.Sprintf("http://%s/files/%s", c.config.Addr, p))
 	if err != nil {
 		if httputil.IsNotFound(err) {
 			return nil, backenderrors.ErrBlobNotFound
@@ -107,7 +106,7 @@ func (c *Client) Upload(namespace, name string, src io.Reader) error {
 		return fmt.Errorf("pather: %s", err)
 	}
 	_, err = httputil.Post(
-		fmt.Sprintf("https://%s/files/%s", c.config.Addr, p),
+		fmt.Sprintf("http://%s/files/%s", c.config.Addr, p),
 		httputil.SendBody(src))
 	return err
 }
@@ -118,8 +117,7 @@ func (c *Client) Download(namespace, name string, dst io.Writer) error {
 	if err != nil {
 		return fmt.Errorf("pather: %s", err)
 	}
-	resp, err := httputil.Get(
-		fmt.Sprintf("https://%s/files/%s", c.config.Addr, p))
+	resp, err := httputil.Get(fmt.Sprintf("http://%s/files/%s", c.config.Addr, p))
 	if err != nil {
 		if httputil.IsNotFound(err) {
 			return backenderrors.ErrBlobNotFound
@@ -145,7 +143,7 @@ func (c *Client) List(prefix string, opts ...backend.ListOption) (*backend.ListR
 	}
 
 	resp, err := httputil.Get(
-		fmt.Sprintf("https://%s/list/%s", c.config.Addr, path.Join(c.pather.BasePath(), prefix)))
+		fmt.Sprintf("http://%s/list/%s", c.config.Addr, path.Join(c.pather.BasePath(), prefix)))
 	if err != nil {
 		return nil, err
 	}