Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL(s) where the issue occurs
DPG Media owns lots of sites. They mostly redirect to
https://myprivacy.dpgmedia.[nl|be]/consent?callbackUrl=<site>&siteKey=<key>
to handle user consent. A few examples:https://www.hln.be/
https://nu.nl/
https://tweakers.net/
The dpgmedia.nl and dpgmedia.be websites themselves redirect to myprivacy.dpgmediagroup.net and need the additional rule (which was already there). I'm not sure if any other sites use the .net redirect.
Describe the issue
DPG Media sites have been broken for quite a while now. Old rules didn't work anymore. I checked all the sites that were specified in the lines I removed, none of those lines did anything. The lines I added fixed all of them, save for 1 or 2 that didn't need any fixing.
Versions
I used a new browser profile with default settings and uBO added.
Settings
Notes
The original rules allowed social media embeds. Do we want that? This PR rejects all. When a YouTube video or a tweet cannot be shown, a message is shown by the website that the embed cannot be shown due to current privacy settings, with a link that opens the consent dialog for the user to change them, see e.g.
https://tweakers.net/video/19750/dit-zijn-de-nieuwe-samsung-galaxy-s25-s25+-en-s25-ultra.html
which has a YouTube video embedded.