Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DPG Media consent dialogs #27017

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kaoneko
Copy link

@kaoneko kaoneko commented Jan 30, 2025

URL(s) where the issue occurs

DPG Media owns lots of sites. They mostly redirect to https://myprivacy.dpgmedia.[nl|be]/consent?callbackUrl=<site>&siteKey=<key> to handle user consent. A few examples:

  • https://www.hln.be/
  • https://nu.nl/
  • https://tweakers.net/

The dpgmedia.nl and dpgmedia.be websites themselves redirect to myprivacy.dpgmediagroup.net and need the additional rule (which was already there). I'm not sure if any other sites use the .net redirect.

Describe the issue

DPG Media sites have been broken for quite a while now. Old rules didn't work anymore. I checked all the sites that were specified in the lines I removed, none of those lines did anything. The lines I added fixed all of them, save for 1 or 2 that didn't need any fixing.

Versions

  • Browser/version: Firefox 134.0.2
  • uBlock Origin version: 1.62.0

I used a new browser profile with default settings and uBO added.

Settings

  • Activated EasyList – Cookie Notices and uBlock filters – Cookie Notices

Notes

The original rules allowed social media embeds. Do we want that? This PR rejects all. When a YouTube video or a tweet cannot be shown, a message is shown by the website that the embed cannot be shown due to current privacy settings, with a link that opens the consent dialog for the user to change them, see e.g. https://tweakers.net/video/19750/dit-zijn-de-nieuwe-samsung-galaxy-s25-s25+-en-s25-ultra.html which has a YouTube video embedded.

Old rules didn't work anymore.
@kaoneko
Copy link
Author

kaoneko commented Jan 31, 2025

@krystian3w What's the thumbs down for? I'm just trying to help out here, please tell me if I'm doing it wrong, it's my first contribution.

@krystian3w
Copy link
Contributor

Rather, the premise of the list is different and it is up to you to own list add stronger privacy policy prohibitions to manually accept social media iframes.

@kaoneko
Copy link
Author

kaoneko commented Jan 31, 2025

This PR will stop cookie walls from appearing on tens of major Dutch language websites, I'd say that deserves a thumbs up no matter if it allows embedded social media or not, as it will save thousands of uBlock Origin users a lot of time and frustration as it is. You're welcome.

As for allowing or denying embedded social media, I specifically brought it up because I don't know what the list policy is: maximize privacy or usability. If it's usability, and we want embedded social media to be displayed by default,

+js(trusted-click-element, '#pg-host-shadow-root >>> button#pg-configure-btn, #pg-host-shadow-root >>> button#pg-reject-btn')

can simply be changed to

+js(trusted-click-element, '#pg-host-shadow-root >>> button#pg-configure-btn, #pg-host-shadow-root >>> #purpose-row-SOCIAL_MEDIA input[type="checkbox"], #pg-host-shadow-root >>> button#pg-save-preferences-btn')

I'm not trying to be all grumpy here or start a fight (I'm afraid my words may come across like that in writing), but getting a thumbs down on my very first contribution, which I spent quite some time and effort on to get right and which will benefit lots of people, didn't feel very welcoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants