Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmi #8

Merged
merged 9 commits into from
Mar 9, 2024
Merged

Dmi #8

merged 9 commits into from
Mar 9, 2024

Conversation

hugelgupf
Copy link
Member

No description provided.

Signed-off-by: Chris Koch <[email protected]>
Empty strings are not actually possible in SMBIOS, as the parsing is
ambiguous. Empty strings always signify not specified.

Signed-off-by: Chris Koch <[email protected]>
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 95.40230% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.99%. Comparing base (cac0592) to head (a6f0003).

Files Patch % Lines
dmidecode/struct_parser.go 92.59% 1 Missing and 1 partial ⚠️
dmidecode/type0_bios_information.go 93.75% 0 Missing and 1 partial ⚠️
dmidecode/type1_system_information.go 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   84.80%   84.99%   +0.18%     
==========================================
  Files          24       24              
  Lines        1909     1933      +24     
==========================================
+ Hits         1619     1643      +24     
  Misses        228      228              
  Partials       62       62              
Flag Coverage Δ
amd64-1.21.x 84.99% <95.40%> (+0.18%) ⬆️
amd64-1.22.x 84.99% <95.40%> (+0.18%) ⬆️
arm-1.21.x 82.35% <95.40%> (+0.85%) ⬆️
arm-1.22.x 82.35% <95.40%> (+0.85%) ⬆️
arm64-1.21.x 82.35% <95.40%> (+0.85%) ⬆️
arm64-1.22.x 82.35% <95.40%> (+0.85%) ⬆️
riscv64-1.21.x 82.35% <95.40%> (+0.85%) ⬆️
riscv64-1.22.x 82.35% <95.40%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
@hugelgupf hugelgupf merged commit 8af75a6 into main Mar 9, 2024
35 checks passed
@hugelgupf hugelgupf deleted the dmi branch March 9, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant