Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: API client to normalize only booleans not integers #56

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix: API client to normalize only booleans not integers #56

merged 1 commit into from
Jul 25, 2024

Conversation

chimd715
Copy link
Contributor

Change Summary

In src/typesense/api_call.py updated normalize_params function to normalize only when the value is boolean.
Reason for the change is that api_call.py automatically converts integer values such as 0 and 1 to string true or false. Hence, querying by page=1 raises error.

Related #41

PR Checklist

@kishorenc kishorenc merged commit 5b9d310 into typesense:master Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorenc kishorenc kishorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chimd715 @kishorenc