Add lambda-otel4s module #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 23, 2024
alexcardell
force-pushed
the
lambda-otel4s
branch
from
6b6999d to
4242256
Compare
|
Currently pointed at a local snapshot so CI will definitely fail, as otel4s main has |
iRevive
reviewed
Mar 31, 2024
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/FaasAttributes.scala
Outdated
Show resolved
Hide resolved
iRevive
reviewed
Mar 31, 2024
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/TracedHandler.scala
Outdated
Show resolved
Hide resolved
iRevive
reviewed
Mar 31, 2024
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/package.scala
Outdated
Show resolved
Hide resolved
|
@iRevive Updated all the attributes and removed semconv-experimental Would appreciate another look when you have time |
|
@alexcardell the changes look good. We still need to wait for a release of https://github.com/http4s/http4s-otel4s-middleware, right? |
|
The middleware would be useful for the example, but I don't believe it's necessary otherwise |
This is to allow consumers the choice of natchez or otel4s No breaking changes except requiring a `feral.lambda.natchez._` import
Co-authored-by: Maksym Ochenashko <[email protected]>
|
so fast!! |
|
Updated |
armanbilge
reviewed
Sep 27, 2024
armanbilge
reviewed
Sep 27, 2024
armanbilge
reviewed
Sep 27, 2024
lambda-otel4s/shared/src/main/scala/feral/lambda/otel4s/TracedHandler.scala
Outdated
Show resolved
Hide resolved
lambda-otel4s/jvm/src/test/scala/feral/lambda/otel4s/TracedHandlerSuite.scala
Outdated
Show resolved
Hide resolved
alexcardell
force-pushed
the
lambda-otel4s
branch
from
eb990d6 to
bb2970f
Compare
|
There is a compatible pre-release of the http4s-otel4s - https://github.com/http4s/http4s-otel4s-middleware/releases/tag/v0.9.0-rc.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #456
This is targeting otel4s 0.11.0
Links
https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/
https://opentelemetry.io/docs/specs/semconv/faas/faas-spans/