-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bazel rules for C# packaging, distribution and documentation #406
Merged
farost
merged 20 commits into
typedb:development
from
farost:csharp-documentation-deployment
Apr 4, 2024
Merged
Changes from 13 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
41cebda
Adapt doxygen rules to C#
farost 0c8ffb8
Add static members extraction for the doxygen generation
farost 3033189
Add nuget_pack rule
farost 542a6f0
Fix struct and license for nuget
farost 567923c
Make native libs one per build
farost 5e4c5a4
Remove mandatory from platforms
farost 1f0f6c4
Fix build
farost 6445e2b
Add first nuget_push version
farost fc3cdfd
Add a good version of nuget push
farost 56e44a2
Adjust the rule for packages with native and without native libs
farost 5a475f0
Refactor the rule to be scalable and with better ux
farost 8b9e003
Refactor the rules to generate packages for several platforms
farost 99ced92
Support version var
farost de59632
Make the rule executable for windows
farost b43e240
Try to change subprocess call to args list
farost 36a5e5d
Add prints to check paths
farost 6c1f209
Add subdirs logging to the python script for debugging
farost 316fbd2
Add more logs for path in python script
farost 454decb
Add more runtime files for push for windows
farost 6888571
Remove prints
farost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ def _doxygen_docs_impl(ctx): | |
files.extend(target.files.to_list()) | ||
|
||
replacements = { | ||
"PROJECT_NAME": ctx.attr.project_name, | ||
"PROJECT_NAME": '"' + ctx.attr.project_name + '"', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed to scale from just cpp to cpp + csharp. |
||
"PROJECT_NUMBER" : ctx.attr.version, | ||
"PROJECT_BRIEF" : ctx.attr.desc, | ||
"OUTPUT_DIRECTORY" : output_directory.path, | ||
|
@@ -90,15 +90,15 @@ doxygen_docs = rule( | |
), | ||
"_doxyfile_template" : attr.label( | ||
allow_single_file = True, | ||
default = "//docs:cpp/doxyfile.template" | ||
default = "//docs:doxygen/doxyfile.template" | ||
), | ||
"_output_directory" : attr.string( | ||
doc = "The output directory for the doxygen docs", | ||
default = "doxygen_docs" | ||
) | ||
}, | ||
doc = """ | ||
Creates HTML documentation for C++ projects using Doxygen. | ||
Creates HTML documentation for C++ and C# projects using Doxygen. | ||
This rule is not hermetic, and requires doxygen to be installed on the host. | ||
""" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't affect the C++ documentation (as it doesn't have docs for static classes -> doesn't need it) but is needed for the C# docs.